No, there is no expiration date on unclaimed complimentary Diamond memberships. They will be available indefinitely, provided that your account is valid and active (i.e., you’ve made an eligible miles transaction within the past 18 months).
For more information, please refer to "How can I keep my Cathay account active?"